Repository navigation
fix(desktop): remove browser pane tooltips and restyle pane/preset tooltips - #5870
Merged
Merged
Conversation
…oltips Remove tooltips from browser back/forward/reload buttons and the shared close-pane button (v1 + v2). Restyle the split-pane and Manage Presets tooltips to the subtle hotkey-chip style with a 1s hover delay. Claude-Session: https://claude.ai/code/session_01CxPkcBBWZeaNygsF9dwMCH
Contributor
📝 WalkthroughWalkthroughTooltip rendering is standardized across pane actions and preset controls, close-pane hotkey tooltips are removed, and browser navigation buttons no longer display hover tooltips while retaining their existing actions and loading states. ChangesPane tooltip behavior
Estimated code review effort: 2 (Simple) | ~15 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/panes/src/react/types.ts`:
- Line 9: Add a required ariaLabel field to the pane action type in
packages/panes/src/react/types.ts, supporting the existing renderer pattern if
needed, and resolve/apply it to the rendered button in
packages/panes/src/react/components/PaneHeaderActions/PaneHeaderActions.tsx. Add
aria-label="Close pane" in the specified PaneToolbarActions component. In both
specified BrowserToolbar files, add accessible labels for the Back, Forward, and
Reload/Loading buttons, using the loading state’s appropriate label.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3904001a-82be-4345-98bb-a9d690f5d574
📒 Files selected for processing (13)
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/V2PresetsBar/V2PresetsBar.tsxapps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useDefaultPaneActions/useDefaultPaneActions.tsxapps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/BrowserPane/components/BrowserToolbar/BrowserToolbar.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/BrowserPane.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/BrowserToolbar/BrowserToolbar.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/ChatPane/ChatPane.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/CommentPane/CommentPane.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/DevToolsPane/DevToolsPane.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/components/PaneToolbarActions/PaneToolbarActions.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/components/PresetsBar/PresetsBar.tsxpackages/panes/src/react/components/PaneHeaderActions/PaneHeaderActions.tsxpackages/panes/src/react/types.ts
💤 Files with no reviewable changes (6)
- apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/ChatPane/ChatPane.tsx
- apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/CommentPane/CommentPane.tsx
- apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane.tsx
- apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useDefaultPaneActions/useDefaultPaneActions.tsx
- apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/DevToolsPane/DevToolsPane.tsx
- apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/BrowserPane.tsx
| key: string; | ||
| icon: ReactNode | ((context: RendererContext<TData>) => ReactNode); | ||
| tooltip: ReactNode | ((context: RendererContext<TData>) => ReactNode); | ||
| tooltip?: ReactNode | ((context: RendererContext<TData>) => ReactNode); |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
Add accessible names before removing tooltip-only labels.
Tooltip removal is fine, but these SVG-only buttons need aria-labels so screen-reader users can identify and operate them.
packages/panes/src/react/types.ts#L9-L9: add a requiredariaLabelfield (supporting the same renderer pattern if needed).packages/panes/src/react/components/PaneHeaderActions/PaneHeaderActions.tsx#L28-L44: resolve and apply that label to the rendered<button>.apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/components/PaneToolbarActions/PaneToolbarActions.tsx#L49-L55: addaria-label="Close pane".apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/BrowserPane/components/BrowserToolbar/BrowserToolbar.tsx#L111-L137: label Back, Forward, and Reload/Loading.apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/BrowserToolbar/BrowserToolbar.tsx#L116-L142: label Back, Forward, and Reload/Loading.
Suggested shared contract
export interface PaneActionConfig<TData> {
key: string;
icon: ReactNode | ((context: RendererContext<TData>) => ReactNode);
+ ariaLabel: string | ((context: RendererContext<TData>) => string);
tooltip?: ReactNode | ((context: RendererContext<TData>) => ReactNode);
onClick: (context: RendererContext<TData>) => void;
}📍 Affects 5 files
packages/panes/src/react/types.ts#L9-L9(this comment)packages/panes/src/react/components/PaneHeaderActions/PaneHeaderActions.tsx#L28-L44apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/components/PaneToolbarActions/PaneToolbarActions.tsx#L49-L55apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/BrowserPane/components/BrowserToolbar/BrowserToolbar.tsx#L111-L137apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/BrowserToolbar/BrowserToolbar.tsx#L116-L142
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/panes/src/react/types.ts` at line 9, Add a required ariaLabel field
to the pane action type in packages/panes/src/react/types.ts, supporting the
existing renderer pattern if needed, and resolve/apply it to the rendered button
in packages/panes/src/react/components/PaneHeaderActions/PaneHeaderActions.tsx.
Add aria-label="Close pane" in the specified PaneToolbarActions component. In
both specified BrowserToolbar files, add accessible labels for the Back,
Forward, and Reload/Loading buttons, using the loading state’s appropriate
label.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BrowserToolbar)PaneToolbarActionsand v2useDefaultPaneActions(madetooltipoptional in@superset/panesPaneActionConfigand render a plain button when absent)closeHotkeyIdprop fromPaneToolbarActionsand its five call sitesbg-background, no arrow) with a 1s hover delay, matching the preset-itemHotkeyTooltipsTest Plan
bun run lintpassesturbo typecheckpasses for@superset/desktopand@superset/paneshttps://claude.ai/code/session_01CxPkcBBWZeaNygsF9dwMCH
Summary by cubic
Removed tooltips from browser pane navigation and close actions, and restyled split-pane and “Manage Presets” tooltips to a subtle hotkey-chip style with a 1s hover delay.
tooltipoptional in@superset/panesPaneActionConfigand render a plain button when absent.closeHotkeyIdfrom desktopPaneToolbarActionsand all call sites.Written for commit d054648. Summary will update on new commits.
Summary by CodeRabbit